regression: Fix rubocop cleanup #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On master, the following code:
```puppet
elasticsearch_plugin { 'ingest-attachment':
ensure => 'present',
}
```
produces the following error:
```
Debug: Runtime environment: puppet_version=7.13.1, ruby_version=2.7.3, run_mode=user, default_encoding=UTF-8
Debug: Evicting cache entry for environment :production
Debug: Deleted text domain :production: false
Debug: Caching environment :production (ttl = 0 sec)
Debug: Evicting cache entry for environment :production
Debug: Deleted text domain :production: false
Debug: Facter: Resolving facts sequentially
Debug: Facter: resolving fact with user_query: osfamily
Debug: Facter: Searching fact: osfamily in file: osfamily.rb
Debug: Facter: Searching fact: osfamily in core facts and external facts
Debug: Facter: Loading all internal facts
Debug: Facter: List of resolvable facts: [#<Facter::SearchedFact:0x000055817d4a4738 @name="osfamily", @fact_class=Facts::Linux::Os::Family, @user_query="osfamily", @type=:legacy, @file=nil>]
Debug: Facter: Loading external facts
Debug: Facter: fact "osfamily" has resolved to: Debian
Debug: Loaded state in 0.08 seconds
Debug: Elasticsearch_plugin[ingest-attachment](provider=elasticsearch_plugin): ingest-attachment: exists? method in elastic_plugin.rb
Error: /Elasticsearch_plugin[ingest-attachment]: Could not evaluate: wrong number of arguments (given 3, expected 2)
Debug: Finishing transaction 10000
Debug: Storing state
Debug: Pruned old state cache entries in 0.00 seconds
Debug: Stored state in 0.03 seconds
Debug: Elasticsearch_plugin[ingest-attachment](provider=elasticsearch_plugin): ingest-attachment: exists? method in elastic_plugin.rb
Error: Could not run: wrong number of arguments (given 3, expected 2)
```
Before RuboCop went rouge, the method header looked like this:
```
def self.plugin_split(original_string, position, soft_fail = true)
```
master has `soft_fail` as a symbol and that produces the above error
messsage. This commits reverts it and it works locally for me again.
bastelfreak
force-pushed
the
regression
branch
from
3a73b78 to
12e8246
Compare
jstraw
approved these changes
Jan 7, 2022
smortex
reviewed
Jan 7, 2022
| @@ -17,7 +17,7 @@ def self.plugin_version(raw_name) | |||
| end | |||
|
|
|||
| # Attempt to guess at the plugin's final directory name | |||
| def self.plugin_split(original_string, position, soft_fail: true) | |||
| def self.plugin_split(original_string, position, soft_fail = true) # rubocop:disable Style/OptionalBooleanParameter | |||
There was a problem hiding this comment.
This seems to be called only once on line 13. What about following rubocop advice and fix that line:
- v = plugin_split(raw_name, 2, false).gsub(%r{^[^0-9]*}, '')
+ v = plugin_split(raw_name, 2, soft_fail: false).gsub(%r{^[^0-9]*}, '')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, the following code:
produces the following error:
Before RuboCop went rouge, the method header looked like this:
master has
soft_failas a symbol and that produces the above errormesssage. This commits reverts it and it works locally for me again.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues