-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit for shield. users and roles only #464
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
1 similar comment
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Can one of the admins verify this patch? |
@bilsch thank you very much for the contribution. |
@electrical No problem. Looking forward to your module. I was thinking of refactoring the user add / manip as its kinda naive right now - only adds a user. No password validation and the role management only occurs at user creation. Feel free to ping me - happy to help and/or test things out. |
@electrical can you publish the shield module before you leave? |
@electrical @cdenneen curious what ever happened to the shield puppet module you guys are working on? |
@bilsch I wasn't working on this. @electrical was but left es so no idea if its still coming. Might want to try to write one or redo your PR with new maintainer |
@tylerjl are you able to push shield repo publicly, even if it is just a pre-release? |
@cdenneen if I'm able to, then yep, I'll get it out for early feedback. |
I am not sure if this is something you guys will want to merge directly. For now it is working for my specific use case.
It does not cover much for shield, only user addition and role assignment/password at the time of creation. If the user password changes this manifest will not cover the case. Ditto if roles change.
Mainly I'm looking to see something along the lines discussed in #433 and #399.
The comment discussed in #433 looks to have some kind of dependency on the plugin manager. I started a thread to discuss what I'm trying to accomplish. There seems to be a disconnect in the instances logic and how plugin works/expects things.