Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for shield. users and roles only #464

Closed
wants to merge 2 commits into from

Conversation

bilsch
Copy link

@bilsch bilsch commented Oct 14, 2015

I am not sure if this is something you guys will want to merge directly. For now it is working for my specific use case.

It does not cover much for shield, only user addition and role assignment/password at the time of creation. If the user password changes this manifest will not cover the case. Ditto if roles change.

Mainly I'm looking to see something along the lines discussed in #433 and #399.

The comment discussed in #433 looks to have some kind of dependency on the plugin manager. I started a thread to discuss what I'm trying to accomplish. There seems to be a disconnect in the instances logic and how plugin works/expects things.

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

1 similar comment
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

@electrical
Copy link

@bilsch thank you very much for the contribution.
I've decided not to merge this in the current Elasticsearch module but i will be starting a shield module pretty soon ( initial version is almost done ) where i will add user management eventually as well.
Most likely this will be done via other ways then invoking the binaries.

@electrical electrical closed this Jan 14, 2016
@bilsch
Copy link
Author

bilsch commented Jan 14, 2016

@electrical No problem. Looking forward to your module.

I was thinking of refactoring the user add / manip as its kinda naive right now - only adds a user. No password validation and the role management only occurs at user creation. Feel free to ping me - happy to help and/or test things out.

@cdenneen
Copy link
Contributor

cdenneen commented Feb 4, 2016

@electrical can you publish the shield module before you leave?

@bilsch
Copy link
Author

bilsch commented Mar 4, 2016

@electrical @cdenneen curious what ever happened to the shield puppet module you guys are working on?

@cdenneen
Copy link
Contributor

cdenneen commented Mar 4, 2016

@bilsch I wasn't working on this. @electrical was but left es so no idea if its still coming. Might want to try to write one or redo your PR with new maintainer

@cdenneen
Copy link
Contributor

@tylerjl are you able to push shield repo publicly, even if it is just a pre-release?

@tylerjl
Copy link
Contributor

tylerjl commented Mar 22, 2016

@cdenneen if I'm able to, then yep, I'll get it out for early feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants