Try to correct unsafe_interpolations lint check

voxpupuli · Aug 25, 2023 · 1a97f62 · 1a97f62
1 parent c36c053
commit 1a97f62
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -175,7 +175,7 @@
 
   if $default_zone {
     exec { 'firewalld::set_default_zone':
-      command => "firewall-cmd --set-default-zone ${default_zone} || firewall-offline-cmd --set-default-zone ${default_zone}",
+      command => ['firewall-cmd --set-default-zone ', $default_zone, ' || firewall-offline-cmd --set-default-zone ', $default_zone],
       unless  => "[ $(firewall-cmd --get-default-zone || firewall-offline-cmd --get-default-zone) = ${default_zone} ]",
       require => Service['firewalld'],
     }
@@ -185,7 +185,7 @@
 
   if $log_denied {
     exec { 'firewalld::set_log_denied':
-      command => "firewall-cmd --set-log-denied ${log_denied} || firewall-offline-cmd --set-log-denied ${log_denied}",
+      command => ['firewall-cmd --set-log-denied ', $log_denied, ' || firewall-offline-cmd --set-log-denied ', $log_denied],
       unless  => "[ $(firewall-cmd --get-log-denied || firewall-offline-cmd --get-log-denied) = ${log_denied} ]",
       require => Service['firewalld'],
     }