Cannot create rich rule with reject type

[bmagistro]

Using the following:
Puppet Agent: 5.5.3
Puppet Server: 5.3.4
firewalld module: master (issue exists on 3.4.0 too)

Using the following rich rule, puppet continually returns an error. I have't been able to track down the cause yet. Zone is present and has other rich rules associated. Under master, I get "Rule action hash should contain 'action' and 'type' keys. ... Got { "action"=>"reject", "type"=>"icmp-net-unreachable"}. Changing "lib/puppet_x/firewalld/property/rich_rule_action.rb" line 10 to if value.keys.sorted != ["action", "type"] I can get past this but then get "Authorized action values are ... got" implying something from the hash isn't being access/passed cleanly.

firewalld_rich_rule { 'rich_rule':
  ensure => 'present',
  zone => 'myzone',
  port => { 'port' => 12345, 'protocol' => 'tcp', },
  action => { 'action' => 'reject', 'type' => 'icmp-net-unreachable', },
}

Edit: Light clicked on, after some more experimenting, another change in the file mentioned above and two changes to "lib/puppet/provider/firewall_rich_rule/firewall_cmd.rb" I can get it working. Will look at creating a PR with these changes.

[bmagistro]

Checking in:
OS: CentOS 7.9
Puppet Server: 6.19.0
Puppet Agent: 6.27.1
firewalld (module): v4.4.0

It looks like this is still an issue. Will try to take my old changes and turn this into a proper PR