Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The native types should all autorequire the firewalld service #224

Closed
trevor-vaughan opened this issue Sep 24, 2019 · 4 comments · Fixed by #234
Closed

The native types should all autorequire the firewalld service #224

trevor-vaughan opened this issue Sep 24, 2019 · 4 comments · Fixed by #234

Comments

@trevor-vaughan
Copy link
Collaborator

Per the documentation, if the firewalld service is not running, then various commands may appear to work but, in reality, do not.

I ran across this with firewalld_ipset recently and it could easily be alleviated by adding a simple autorequires to the native types.

@alexjfisher
Copy link
Member

Is #197 (very recently merged) relevant?

@trevor-vaughan
Copy link
Collaborator Author

@alexjfisher Partially. It doesn't actually solve the entire issue which is getting the native types to self-order properly.

Basically anything that runs firewall-cmd must come after Service[firewalld].

@igalic
Copy link
Contributor

igalic commented Sep 26, 2019

aren't Autorquires in types kinda like, friendly suggestions?

@trevor-vaughan
Copy link
Collaborator Author

@igalic Yep, if it exists, use it, if not, don't. But it's a real requires, if it fails, the rest of the chain will fail.

However, this is exactly what we want.

trevor-vaughan added a commit to trevor-vaughan/pupmod-voxpupuli-firewalld that referenced this issue Oct 18, 2019
* Added an autorequire for each native type that uses firewall-cmd. This
  is due to what appears to be the requirement that any firewall-cmd
  activities occur after the service has been started the first time.
  Running commands prior to the service start can result in malformed
  configurations being applied to the system which silently break the
  firewalld service.
* Tested against simp/iptables 6.4.0

Closes voxpupuli#224
trevor-vaughan added a commit to trevor-vaughan/pupmod-voxpupuli-firewalld that referenced this issue Oct 18, 2019
* Added an autorequire for each native type that uses firewall-cmd. This
  is due to what appears to be the requirement that any firewall-cmd
  activities occur after the service has been started the first time.
  Running commands prior to the service start can result in malformed
  configurations being applied to the system which silently break the
  firewalld service.
* Tested against simp/iptables 6.4.0

Closes voxpupuli#224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants