Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The firewalld_version fact is incorrect when firewalld is not running #263

Closed
trevor-vaughan opened this issue Feb 27, 2020 · 0 comments · Fixed by #264
Closed

The firewalld_version fact is incorrect when firewalld is not running #263

trevor-vaughan opened this issue Feb 27, 2020 · 0 comments · Fixed by #264

Comments

@trevor-vaughan
Copy link
Collaborator

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: All
  • Ruby: All
  • Distribution: All
  • Module version: 4.2.2

How to reproduce (e.g Puppet code you use)

Disable firewalld and get the fact from facter

What are you seeing

An empty string is returned

What behaviour did you expect instead

A version number should be returned

Any additional information you'd like to impart

This is a bug in upstream firewalld. The following python code can be used to get the version directly:

import firewall.config; print(firewall.config.__dict__['VERSION'])

Working on a patch to incorporate that fix.
trevor-vaughan added a commit to trevor-vaughan/pupmod-voxpupuli-firewalld that referenced this issue Feb 28, 2020
@trevor-vaughan
Fix the firewalld_version fact
befefc3 
* Work around a bug in firewall-cmd and use raw python to get the
  firewalld version if firewalld-cmd does not return anything
* Incorporated the simp-beaker-helpers gem to get access to the helper
  methods

Fixes voxpupuli#263
@trevor-vaughan trevor-vaughan mentioned this issue Feb 28, 2020
Merged
trevor-vaughan added a commit to trevor-vaughan/pupmod-voxpupuli-firewalld that referenced this issue Feb 28, 2020
@trevor-vaughan
Fix the firewalld_version fact
cb1ca7c 
* Work around a bug in firewall-cmd and use raw python to get the
  firewalld version if firewalld-cmd does not return anything
* Incorporated the simp-beaker-helpers gem to get access to the helper
  methods

Fixes voxpupuli#263
trevor-vaughan added a commit to trevor-vaughan/pupmod-voxpupuli-firewalld that referenced this issue Feb 28, 2020
@trevor-vaughan
Fix the firewalld_version fact
88a0b86 
* Work around a bug in firewall-cmd and use raw python to get the
  firewalld version if firewalld-cmd does not return anything
* Incorporated the simp-beaker-helpers gem to get access to the helper
  methods

Fixes voxpupuli#263
trevor-vaughan added a commit to trevor-vaughan/pupmod-voxpupuli-firewalld that referenced this issue Mar 3, 2020
@trevor-vaughan
Fix the firewalld_version fact
0c9f443 
* Work around a bug in firewall-cmd and use raw python to get the
  firewalld version if firewalld-cmd does not return anything
* Incorporated the simp-beaker-helpers gem to get access to the helper
  methods

Fixes voxpupuli#263
trevor-vaughan added a commit to trevor-vaughan/pupmod-voxpupuli-firewalld that referenced this issue Mar 3, 2020
@trevor-vaughan
Fix the firewalld_version fact
6ab68b8 
* Work around a bug in firewall-cmd and use raw python to get the
  firewalld version if firewalld-cmd does not return anything
* Incorporated the simp-beaker-helpers gem to get access to the helper
  methods

Fixes voxpupuli#263
jovandeginste pushed a commit to kuleuven/puppet-firewalld that referenced this issue Mar 6, 2020
@trevor-vaughan @jovandeginste
Fix the firewalld_version fact
340fdc4 
* Work around a bug in firewall-cmd and use raw python to get the
  firewalld version if firewalld-cmd does not return anything
* Incorporated the simp-beaker-helpers gem to get access to the helper
  methods

Fixes voxpupuli#263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the firewalld_version fact trevor-vaughan/pupmod-voxpupuli-firewalld
1 participant
@trevor-vaughan