Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update firewalld custom service to translate port ranges with a colon… #293

Merged
merged 1 commit into from
May 28, 2020
Merged

Update firewalld custom service to translate port ranges with a colon… #293

merged 1 commit into from
May 28, 2020

Conversation

csschwe
Copy link
Contributor

@csschwe csschwe commented May 14, 2020

… in hashes

Pull Request (PR) description

Make sure colon is replaced with a dash with firewalld_custom_service when using a port range in a hash

This Pull Request (PR) fixes the following issues

Fixes #292

alexjfisher
alexjfisher approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Pinging @trevor-vaughan just in case.

@csschwe
Copy link
Contributor Author

csschwe commented May 28, 2020

Any concerns? Would be nice to get this merged in. thanks

@ghoneycutt ghoneycutt merged commit 79e4203 into voxpupuli:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghoneycutt ghoneycutt ghoneycutt approved these changes

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in version 4.3.0 firewalld_custom_service.rb with port range in hash
3 participants
@csschwe @alexjfisher @ghoneycutt