Fixes firewalld_custom_service where only protocols are defined #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmaludy
force-pushed
the
bugfix/custom-service-protocols
branch
from
6d0a48f to
624065c
Compare
bastelfreak
approved these changes
Apr 7, 2021
|
ping ? |
|
@nmaludy Thanks! (and sorry for the delay). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Previously if you wanted to define a custom service that only allows protocols it would error when adding protocols to the service. This was caused by the Puppet code omitting the
portsarray and the provider assuming that theportsarray was specified.I simply added a check to see if
portsarray was:unsetand if it's:unsetjust skip finding protocols from that array.This Pull Request (PR) fixes the following issues
Fixes #306