Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Breaking: modulesync 1.1.0 with backwards-incompatible changes #68

Merged
merged 11 commits into from
Oct 18, 2017
Merged

Breaking: modulesync 1.1.0 with backwards-incompatible changes #68

merged 11 commits into from
Oct 18, 2017

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak changed the title modulesync 0.21.0 modulesync 0.21.3 Jun 11, 2017
@bastelfreak
Copy link
Member Author

This fixes #69

@bastelfreak bastelfreak changed the title modulesync 0.21.3 modulesync 1.1.0 Sep 15, 2017
@wyardley
Copy link
Contributor

The issue with the tests seems to be the missing dependencies section in metadata. It's odd, because puppet module install works Ok, and the module works in the acceptance test, it's just the spec test that's erroring with a generic failure to include the class.
proletaryo/puppet-supervisor#18

@wyardley wyardley changed the title modulesync 1.1.0 Breaking: modulesync 1.1.0 with backwards-incompatible changes Oct 18, 2017
@wyardley
Copy link
Contributor

Switched to the forge dependency in .fixtures.yml (which doesn't have the broken metadata that git does). I think we can live with having the forge dep in fixtures for the time being

@bastelfreak bastelfreak merged commit 08cd6d9 into master Oct 18, 2017
@bastelfreak bastelfreak deleted the modulesync branch October 18, 2017 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @wyardley @ekohl