modulesync setup #1
Conversation
| @@ -0,0 +1,19 @@ | |||
| FROM ruby:2.4-alpine | |||
There was a problem hiding this comment.
is tehre a reason for not using 2.5?
| "name": "puppet-gitlab-ci-runner", | ||
| "version": "1.0.0-rc0", | ||
| "author": "Vox Pupuli", | ||
| "summary": "Installation and configuration of Gitlab CI Runner", |
| "version": "1.0.0-rc0", | ||
| "author": "Vox Pupuli", | ||
| "summary": "Installation and configuration of Gitlab CI Runner", | ||
| "license": "BSD-3-Clause", |
There was a problem hiding this comment.
Is that licence on purpose? Most of other modules have apache2, but others are fine as well. I just need to recheck how BSD-3 works.
There was a problem hiding this comment.
Not on purpose. I copied this file from the puppet-gitlab module, so I guess it was missed when we transferred that module to VP. I'll update it in both modules.
| "version_requirement": ">=4.13.0 <5.0.0" | ||
| }, | ||
| { | ||
| "name": "puppetlabs/apt", |
There was a problem hiding this comment.
this is a soft dependency (because it isn't needd on the RHEL systems I assume). So it should be added as a note to the README.md, but not added as hard dependency to the metadata.json.
There was a problem hiding this comment.
same deal here. it was in the metadata.json from puppet-gitlab and should be removed in both modules. It only needs to be in .fixtures,yml with some info in README as you have mentioned.
|
@LongLiveCHIEF I merged this to get it going. Can you please check the inline comments I made? |
|
Yeah. The answer to pretty much all of your questions was "I copied the
same file from puppet-gitlab".
…On Sun, Jul 22, 2018, 2:25 PM Tim Meusel ***@***.***> wrote:
Merged #1 <#1>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADIVgQhEL0CmRZEF2K3QAFK-GSZoqa_Tks5uJNG9gaJpZM4VZugc>
.
|
…upuli#1) * Added ca file check * Updated message * Fixed broken end line * with puts * Added spec test * Updated messages * Fixes for rubocop * Fixes for rspec * Remove white space * Updated documentation
Setup modulesync for the module. This should be accepted with voxpupuli/modulesync_config#482