Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refreshes to gluster::mount fail to remount the volume #10

Closed
talisto opened this issue Jan 23, 2015 · 1 comment
Closed

refreshes to gluster::mount fail to remount the volume #10

talisto opened this issue Jan 23, 2015 · 1 comment

Comments

@talisto
Copy link

talisto commented Jan 23, 2015

if a refresh is triggered on a gluster::mount, puppet attempts to remount the filesystem with mount -o remount. This results an error like:

Failed to call refresh: Execution of '/bin/mount -o remount /mnt/foo' returned 1: Invalid option remount

...because gluster FUSE mounts don't support that option.

I propose passing the remounts => false option to the mount directive in the gluster::mount class to avoid this behaviour.
skpy pushed a commit that referenced this issue Jan 23, 2015
Pass remounts => false to mount resources
c877ce0 
As identified in #10, a refresh of a volume will attempt to remount the
volume but the FUSE client does not support this.  Set
[remounts](https://docs.puppetlabs.com/references/3.4.stable/type.html#mount-attribute-remounts) to `false` on the mount resource.

This means that any resource changes will cause the mount to be
***unmounted** and then mounted.
@skpy skpy mentioned this issue Jan 23, 2015
Merged
@skpy skpy closed this as completed in fb29290 Jan 23, 2015
@talisto
Copy link
Author

talisto commented Jan 23, 2015

Great! Thanks all your hard work on this module, it's much appreciated!

cegeka-jenkins pushed a commit to cegeka/puppet-gluster that referenced this issue Jul 20, 2018
Pass remounts => false to mount resources
5a0fe7a 
As identified in voxpupuli#10, a refresh of a volume will attempt to remount the
volume but the FUSE client does not support this.  Set
[remounts](https://docs.puppetlabs.com/references/3.4.stable/type.html#mount-attribute-remounts) to `false` on the mount resource.

This means that any resource changes will cause the mount to be
***unmounted** and then mounted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@talisto