-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo release and version logic broken? #187
Comments
Also I don't understand why https://github.com/voxpupuli/puppet-gluster/blob/master/manifests/repo.pp |
jacksgt
added a commit
to vision-it/vision-gluster
that referenced
this issue
Dec 4, 2018
Yes, it's weird 😕 For Debian repositories you need to explicitly set the release
as the variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
maybe I'm just not getting the logic of this module (if so please correct me!), but I think there is an error in the way this module handles the repository version (at least for Debian systems).
Starting in init.pp, I can specify two parameters concerning the package version number to be installed:
release
andversion
. (BTW: at the top of the file only one of them is documented)puppet-gluster/manifests/init.pp
Line 44 in 72a80cd
But
init.pp
itself passes onlyversion
onto::gluster::install
:Because install.pp can only handle
version
, but notrelease
.This makes sense as
::gluster::install
deals with installing the packages, but not setting up the repositories.However, the availability of the
release
parameter ininit.pp
lead me to assume I can configure both the packages and the repository through the main package (because enabling or disabling the repository is also possible throughinit.pp
), like so:This will simply lead to the creation of the file
/etc/apt/sources.list.d/glusterfs-4.1.list
:Which is obviously not what I wanted (the URL points to gluster 3.12).
This happens because
install.pp
includesrepo.pp
(if that has not already been done), but only passes theversion
parameter ontorepo.pp
.Since repo.pp does then not know about the
release
parameter I specified ininit.pp
, it simply uses the default from params.pp:puppet-gluster/manifests/params.pp
Line 27 in 72a80cd
Can someone please confirm or deny this observation?
I'd be happy to discuss and submit a PR.
The text was updated successfully, but these errors were encountered: