Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow volumes without replicas #168

Merged
merged 4 commits into from
Jul 1, 2018
Merged

Allow volumes without replicas #168

merged 4 commits into from
Jul 1, 2018

Conversation

glorpen
Copy link
Contributor

@glorpen glorpen commented Jun 25, 2018

This PR is strongly based on work in #92 but it is updated to current master and with one more test.

Fixes #88
Closes #92

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it makes sense but I wonder if $options needs a similar treatment. Could you have a look while you're at it?

@glorpen
Copy link
Contributor Author

glorpen commented Jun 25, 2018

Not sure if it is what you wanted;
$options (and $_options) can be undef or array and is expected by code to be just that, I would only force string content with parameter type - Optional[Array[String]] but then gluster::volume::setting has non-typed parameter.

@ekohl
Copy link
Member

ekohl commented Jun 25, 2018

I meant

$_options = undef

@glorpen
Copy link
Contributor Author

glorpen commented Jun 25, 2018

well, there was a bug :)

@ekohl
Copy link
Member

ekohl commented Jun 25, 2018

I had a look and I think that #169 cleans up it a lot by using Puppet 4 language constructs. Haven't actually tested it so let's see if the tests pass :)

@glorpen
Copy link
Contributor Author

glorpen commented Jun 30, 2018

@ekohl can we merge this? I think it would be nice since this PR contains changes from Dec 2016.

@ekohl ekohl merged commit e10fda6 into voxpupuli:master Jul 1, 2018
@ekohl
Copy link
Member

ekohl commented Jul 1, 2018

Thanks!

@glorpen
Copy link
Contributor Author

glorpen commented Jul 1, 2018

Big thanks :)

@glorpen glorpen deleted the noreplica branch July 1, 2018 06:58
@alexjfisher alexjfisher added the enhancement New feature or request label Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants