-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3.8 repo, use pl-apt 4.4 https support, clean coding #170
Conversation
Hi @ekohl, can you rebase please? |
Rebased |
Rebased again |
Why do I have a feeling that https for apt is broken every two weeks? :( |
Could be. Wonder if there's some chaining missing. |
@ekohl I think you should not remove the package |
Because puppetlabs-apt is supposed to guarantee that: https://github.com/puppetlabs/puppetlabs-apt/blob/0dba15a9c62ce4d98435eac89e0087a2ad00ce10/manifests/source.pp#L85-L94 |
I did copy that part yes because I think it's more correct. I can leave it out for now and merge it in a separate PR. |
Updated. The http -> https URL change should also fix the failing puppetlabs-apt tests. That does a regex on the URL to decide. |
6c8cd83
to
8097b31
Compare
|
||
# basic sanity check | ||
if $version == 'LATEST' { | ||
$repo_ver = $version | ||
} elsif $version =~ /^\d\.\d+$/ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to convert this into a datatype?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that much because AFAIK you can't really extract variables from a data type like we do in the case below. You could avoid the else case at the end, but an if/elsif/elsif tree without an else feels wrong to me.
@ekohl can you please rebase and give me a hint afterwards? I would like to review and merge this as soon as possible. |
Rebased |
can you take a look at the failing spec tests? |
The 3.8 release has been removed from the repositories.
Updated |
thanks! |
No description provided.