Use $fact to retrieve fact #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoppe
approved these changes
Apr 15, 2020
|
@scornelissen85 I've tried this PR and for hash access there should be no |
|
You're right, I will change that. |
Merged
|
Looks good, but needs a rebase to fix the merge conflict. Mind also squashing the commits while you're at it? |
scornelissen85
force-pushed
the
master
branch
2 times, most recently
from
3cf789f
to
2ed2cf2
Compare
|
Well, I just merged #219 and of course that also introduced merge conflicts. Sorry. |
|
Hi everyone... the tests seem to be all green, can we hope to have a merge in the next time then? ;-) Greetings, Robert |
ekohl
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
It will use the Puppet variable
$factto retrieve a fact name. Before this change, it usedgetvar()and in Puppet 6 the build-ingetvar()is used which don't support a dash-in it's variable name. We had the challenge with migration to Puppet 6 this code failed because we have a volume with the nametest-vol1(with a dash). With this change the Puppet code will build a catalog on Puppet 6. A fact may actually contain a dash andgetvar()shouldn't be used for getting a fact variable.This Pull Request (PR) fixes the following issues
Fixes #214