Debian support #59
Debian support #59
Conversation
| @@ -33,6 +33,14 @@ | |||
| version => $version, | |||
| } | |||
| } | |||
| 'Debian': { | |||
| if ! defined( '::apt' ) { | |||
There was a problem hiding this comment.
I think we should include the apt class here instead of the !defined
There was a problem hiding this comment.
I fear it wouldn't parse if there's no apt module available, but I'll proceed as you prefer
There was a problem hiding this comment.
yep it will fail. I wrote a comment about adding the module to the metadata.json and fixtures as well. This should ensure that the module is available.
There was a longer discussion about soft dependencies and hard dependencies, we decided for hard deps. So we should include the module here + in metadata
|
Hi @NITEMAN, thanks for the PR!
|
|
Hi @bastelfreak :
|
|
@bastelfreak everithing should be right now, let me know if anything more is needed |
|
There are a few broken tests now, can you look into that? |
|
I'll try my best, but I'm a noob in terms of rspec |
|
if you've any questions feel free to join our IRC channel #voxpupuli on freenode. We should be able to solve the issues together. |
remove ubuntu support for now (it'll be easier to add the test only for debian) remove leftover comment
fix typo
fixing tests, take 1 fixing tests, take 2 fixing tests, take 3 fixing tests, take 4 fixing tests, take 5
|
@bastelfreak I think everything is ok right now, but please review carefully rspec files (especially brand new Thank you very much for your support and thanks to @DarkGigabyte for him support ;) PS: I have doubts on style offences highlighted by travis :( |
| end | ||
| it 'installs' do | ||
| should contain_apt__source('glusterfs-LATEST').with( | ||
| :repos => 'main', |
There was a problem hiding this comment.
The expected syntax for this is repos: 'main',. Same change is needed above starting at line 18.
|
thanks for the great work, I will review that tomorrow. Please ping me on IRC if I forget. |
|
A big thank you for @NITEMAN and @bastelfreak for the great work! |
|
|
||
| # basic sanity check | ||
| if $version == 'LATEST' { | ||
| $repo_ver = $version |
There was a problem hiding this comment.
should we use $_version instead of $repo_ver? We already use $_version in the other class, so it woul be consistent naming scheme.
|
Looks really good so far, I just made a little comment. Please take a look and then I'm happy to merge. |
|
nevermind, I'm fine with the different name because it covers a different scope. |
* Add Support for Debina-based distros * Update README to include Debian support * remove repository mess from Ubuntu PPA & Raspbian remove ubuntu support for now (it'll be easier to add the test only for debian) remove leftover comment * fix variable name * fix travis strict complains fixing tests, take 1 fixing tests, take 2 fixing tests, take 3 fixing tests, take 4 fixing tests, take 5 * add apt to .fixtures * remove apt guard fix typo * add puppetlabs/apt hard depencency * add test for repo::apt * change priority behaviour on apt::repo * fix style offences, take 1 * fix style offences, take 2
This PR adds:
I've borrowed some work from another fork.
Please let me know if anything more is needed in order to ofcially support Debian (I wish I know a little rspec to add some basic tests).
Tested on Debian 8