-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vagrant support #9
Conversation
|
I will have a look at this later. the beaker tests for the hyperglass::server class pass the tests currently, so I guesss something with vagrant is wrong. |
@bastelfreak The acceptance test just applies the class and checks that it can be applied and is idempotent. It does not check to see if the service is running. |
3c99c47
to
3b13f2f
Compare
This is ready for merge |
looks good at the moment. I think we should rebase it after #5 got merged because I did a lot of refactoring there. |
@@ -0,0 +1,14 @@ | |||
# If you enable selinux, redis will not be able to write to its data directory | |||
# and will not properly start without the following. | |||
selinux::permissive { 'redis_t': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this? I think the redis module sets correct permissions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah :(
Once I fixed this, then redis worked properly.
Ran into thatmattlove/hyperglass#85 and saw what you did in the agent acceptance tests. Need to add these here so it works in vagrant. In the sensu module there is a similar server/agent setup that uses TLS and we just used the puppet certs, since Puppet gives us a working CA environment. We make it the default way so by using the puppet module you get better security by default. Perhaps hyperglass should do similar. |
@bastelfreak you know if there is a way to query the hyperglass server to see that the agent has connected? ideally the our acceptance tests for agent_and_server would include something that proves the communication is working. |
Yes their current TLS implementation is very specifc. I highly prefer a setup where apps are bound to localhost only and an nginx does TLS termination, if possible with TLS client cert validation. This works perfectly fine with Puppet certificates. Howerver the hyperglass-server does currently not support it. I created a patch for your branch that works on my local machine:
this connects the hyperglass agent to the server |
on a quick look at the docs I couldn't spot any health checks in that we could use in our tests. I asked in their gitter channel. |
@bastelfreak Do you have to add the agent info to the server like that? If so that's odd because the agent is configured to speak to the server so they should know about each other. If that's the normal process, maybe we need some kind of |
Closing in favor of #15 which includes this work with minor modifications. |
@bastelfreak Attempting to see this work locally and running into issues. Not sure if there is a step missing from the code or if the class needs to be called with specific data. Attempting to just
include hyperglass::server