attribute keys are missed for parsing

[lbetz]

The attribute keys are used to identify values that must not quoted thru the parsing mechanism. So we must not delete attribute with an undefined value.

Idea: move delete_undef_value from dedicated object definition to the main object resource and add a new parameter to the attributes function to get a list of unquoted words.

[Reamer]

Hi @lbetz,
If you remove delete_undef_value from dedicated object, we will get Warnings which I described in PR (#222). The icinga2::object is created in each dedicated object. I think "delete_undef_value" function is at last position before Puppetserver tries to save our icinga::object.
Just a thought maybe I am totally wrong.

[lbetz]

Not remove, move to the object define resource ::icinga2::object.

[Reamer]

I'll will take a look into puppetserver log with your patch.

[Reamer]

I checked it in puppetserver log with your patch and all Warnings are now present again. Thats because you removed delete_undef_value from dedicated object.

[lbetz]

OK, that's mean the problem is inside puppet and not between puppet and erb or ruby. Makes sense, puppet is implemented in ruby. Shit so we've to move delete_undef_values back to all objects and implement something to handover the attribute keys for parsing.

[lbetz]

Please try the current commit to branch bug/attribute-keys-are-missed-for-parsing-246.

[Reamer]

Tested with current master and Puppet 4 -> No warning