Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSpec Puppetlabs modules incompatible to Puppet 3 #286

Closed
lazyfrosch opened this issue Apr 21, 2017 · 4 comments · Fixed by #287
Closed

RSpec Puppetlabs modules incompatible to Puppet 3 #286

lazyfrosch opened this issue Apr 21, 2017 · 4 comments · Fixed by #287
Labels
bug
Milestone
v1.3.0

Comments

@lazyfrosch
Copy link
Contributor

Latest releases of some Puppetlabs modules are no longer compatible to Puppet 3, and therefor breaking our tests.

Includes at least:

  • puppetlabs-apt
  • puppetlabs-concat
  • puppetlabs-stdlib

We should find a proper way to split fixtures between Puppet Versions (probably by using different fixtures when PUPPET_VERSION is Puppet < 4)
@lazyfrosch
Copy link
Contributor Author

stdlib seems not yet affected...

lazyfrosch added a commit that referenced this issue Apr 21, 2017
@lazyfrosch
Specify older fixtures for Puppet 3 tests
cade9e6 
refs #286
@lazyfrosch lazyfrosch mentioned this issue Apr 21, 2017
Merged
@lazyfrosch lazyfrosch mentioned this issue Apr 21, 2017
Merged
@bobapple bobapple added bug and removed Puppet3 labels Apr 21, 2017
@bobapple bobapple changed the title Puppetlabs modules incompatible to Puppet 3 RSpec Puppetlabs modules incompatible to Puppet 3 Apr 21, 2017
bobapple added a commit that referenced this issue Apr 21, 2017
@bobapple
Merge branch 'fix/puppet3-tests-286'
47296d3 
fixes #286
@walterheck
Copy link

Isn't Puppet < 4 EOL? https://puppet.com/misc/puppet-enterprise-lifecycle

@bobapple
Copy link
Contributor

@walterheck yes it is. However, there are still plenty of users out there who are using Puppet 3, because a migration (especially in bigger environments) takes ages. Therefore, this module is Puppet 3 compatible.

@lazyfrosch
Copy link
Contributor Author

If we lived in a perfect world...

@bobapple bobapple added this to the v1.2.2 milestone Apr 21, 2017
@bobapple bobapple modified the milestones: v1.3.0, v1.2.2 May 11, 2017
n00by pushed a commit to n00by/puppet-icinga2 that referenced this issue Apr 26, 2018
@lazyfrosch @n00by
Specify older fixtures for Puppet 3 tests
59a10f9 
refs voxpupuli#286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Specify older fixtures for Puppet 3 tests voxpupuli/puppet-icinga2
3 participants
@lazyfrosch @walterheck @bobapple