Boolean 'false' custom variables do not appear in configuration

[ekeih]

We use boolean custom variables in our configuration. They work fine if they are true but they never end up in the configuration file if set to false.

Expected Behavior

false variables should be appear in the generated configuration.

Current Behavior

false variables are ignored. Only true values and non-booleans are used.

Possible Solution

I think the changes in 1ab1c6f are responsible for the bug. The if value conditions evaluate to false so the custom variables are ignored.

Steps to Reproduce (for bugs)

1. Configure a check with boolean custom variables

  icinga2::object::service { 'icinga2':
    ensure               => present,
    import               => [ 'generic-service', ],
    target               => '/etc/icinga2/zones.d/globals.d/services.conf',
    display_name         => 'Icinga2 Status',
    check_interval       => '1m',
    retry_interval       => '30s',
    check_command        => 'icinga',
    zone                 => 'master',
    command_endpoint     => 'host.name',
    apply                => true,
    assign               => [ 'host.vars.check.icinga2.enable == true' ],
    enable_active_checks => false,
    vars                 => {
      enable_active_checks => false,
      bla                  => false,
      foobar               => true,
    }
  }

2. Apply the puppet configuration
3. Check the generated configuration: only the true variables are included.

apply Service "icinga2" to Host {
  import "generic-service"

  display_name = "Icinga2 Status"
  check_command = "icinga"
  check_interval = 1m
  retry_interval = 30s
  enable_active_checks = false
  zone = "master"
  command_endpoint = host.name
  vars.foobar = true
  assign where host.vars.check.icinga2.enable == true
}

Your Environment

• Module version (puppet module list): We are using a fork of the module but it contains the same utils.rb as the latest upstream version.
• Puppet version (puppet -V): 4.10.1
• Operating System and version: Ubuntu 16.04