Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage logging directory and file #173

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

baurmatt
Copy link
Contributor

Fixes #172

@bobapple
Copy link
Contributor

I would prefer to create the directory and file without setting the group to adm

@baurmatt
Copy link
Contributor Author

Which group would you prefer? From my understanding adm is the default group for log files. You can add user to this group which should have only read access.

@bobapple
Copy link
Contributor

I'm not sure if all distributions and syslog daemons actually use the adm group. I've seen it on Debian and Ubuntu, but not on RHEL or SLES. Therefore I thought it would be better to not set the group at all.

@baurmatt
Copy link
Contributor Author

Seems like the group exists on RHEL/SLES but isn't used. I therefor removed the owner and group settings. The defaults from:

  File {
    mode  => '0660',
    owner => $conf_user,
    group => $conf_group
  }

are now getting used.

@bobapple bobapple merged commit 0fd7ed9 into voxpupuli:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants