Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix role documentation typo and table #358

Merged

Conversation

zilchms
Copy link
Contributor

@zilchms zilchms commented Apr 27, 2023

This PR resolves #356.

Note:
The 'puppet strings generate' command needs 2 newlines before a table to render one new line in the resulting markdown.

On a second note:
The discrepancies in the Links of the REFERENCE most likely come from an update of the gems used to generate the REFERENCE.

@cla-bot cla-bot bot added the cla/signed label Apr 27, 2023
@zilchms
Copy link
Contributor Author

zilchms commented Apr 27, 2023

The broken test are cause by a new release of the concurrent-ruby gem, which changes some things.
See: https://bugs.launchpad.net/puppet-openstack-spec-helper/+bug/2003761

Maybe we need to pin the older version temporarily?

@zilchms zilchms changed the title Fix/config role documentation typo 356 Fix role documentation typo and table Apr 27, 2023
@lbetz lbetz self-requested a review April 28, 2023 05:00
@lbetz lbetz added this to the v3.9.0 milestone Apr 28, 2023
@lbetz lbetz merged commit 0982171 into voxpupuli:master Apr 28, 2023
@lbetz
Copy link
Contributor

lbetz commented Apr 28, 2023

The broken test are cause by a new release of the concurrent-ruby gem, which changes some things. See: https://bugs.launchpad.net/puppet-openstack-spec-helper/+bug/2003761

Maybe we need to pin the older version temporarily?

done #359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown permission table for icingaweb2::config::role is broken
2 participants