Issue #215 - Disable user, need to update spec tests #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @cyberious! |
|
@cyberious is this still WIP? |
|
Yes will be pushing changes tomorrow.
…On Wed, Oct 4, 2017 at 11:41 AM Tim Meusel ***@***.***> wrote:
@cyberious <https://github.com/cyberious> is this still WIP?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#223 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABn_HkQxVMB4ojdA1MUHOb96lgBwilqwks5so9FTgaJpZM4PsjOz>
.
|
cyberious
changed the title
|
Updated, was waiting to get back to writing the spec tests around it. |
|
Hi @cyberious, can you take a look at the failing spec tests? |
dhollinger
approved these changes
Oct 6, 2017
|
Is there an ETA when this will be release to Puppet Forge? |
|
@cyberious is there any work left on this PR? |
|
Nope should be gtg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.