Allow defining additional Tomcat connectors #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antaflos
force-pushed
the
additional_connectors
branch
from
62a1c3f
to
f104312
Compare
|
Two out of four acceptance tests are failing in Travis but this is unrelated to my changes. |
|
Dear @antaflos, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Trying to close and re-open to trigger Travis tests again. |
|
The tests are fine now. |
ghoneycutt
reviewed
Jul 3, 2020
ghoneycutt
reviewed
Jul 3, 2020
bastelfreak
reviewed
Jul 5, 2020
antaflos
force-pushed
the
additional_connectors
branch
2 times, most recently
from
f974e64
to
566cb61
Compare
antaflos
added a commit
to antaflos/puppet-confluence
that referenced
this pull request
Jul 28, 2020
Add a new, optional class parameter `confluence::tomcat_additional_connectors` whose value is a well-formed, complex hash as described by the new type aliases `Confluence::Tomcat_connectors` and `Confluence::Tomcat_attributes`. Each hash key represents a port number, and the key's value is a hash that describes the connector's attributes and their values. Useful for defining additional HTTP ports through which to access Confluence. A typical use case is when Jira and Confluence run behind a reverse proxy and application links between Jira and Confluence must be set up. Then it is often better to allow Jira and Confluence to communicate directly instead of through the reverse proxy, but this requires a Tomcat connector that is configured for direct access instead of reverse proxy access (`proxyName`, `proxyPort`, etc). Described here: https://confluence.atlassian.com/kb/how-to-create-an-unproxied-application-link-719095740.html Contains spec tests, documentation and examples. A very similar PR was submitted to puppet-jira in voxpupuli/puppet-jira#316
|
Some test suites are failing now because of lots of bizarre errors like this: This is definitely not caused by my changes. I assume rubocop became much more strict in the last weeks? |
antaflos
added a commit
to antaflos/puppet-confluence
that referenced
this pull request
Jul 28, 2020
Add a new, optional class parameter `confluence::tomcat_additional_connectors` whose value is a well-formed, complex hash as described by the new type aliases `Confluence::Tomcat_connectors` and `Confluence::Tomcat_attributes`. Each hash key represents a port number, and the key's value is a hash that describes the connector's attributes and their values. Useful for defining additional HTTP ports through which to access Confluence. A typical use case is when Jira and Confluence run behind a reverse proxy and application links between Jira and Confluence must be set up. Then it is often better to allow Jira and Confluence to communicate directly instead of through the reverse proxy, but this requires a Tomcat connector that is configured for direct access instead of reverse proxy access (`proxyName`, `proxyPort`, etc). Described here: https://confluence.atlassian.com/kb/how-to-create-an-unproxied-application-link-719095740.html Contains spec tests, documentation and examples. A very similar PR was submitted to puppet-jira in voxpupuli/puppet-jira#316
Add a new, optional class parameter `jira::tomcat_additional_connectors` whose value is a well-formed, complex hash as described by the new type aliases `Jira::Tomcat_connectors` and `Jira::Tomcat_attributes`. Each hash key represents a port number, and the key's value is a hash that describes the connector's attributes and their values. Useful for defining additional HTTP ports through which to access Jira. A typical use case is when Jira and Confluence run behind a reverse proxy and application links between Jira and Confluence must be set up. Then it is often better to allow Jira and Confluence to communicate directly instead of through the reverse proxy, but this requires a Tomcat connector that is configured for direct access instead of reverse proxy access (`proxyName`, `proxyPort`, etc). Described here: https://confluence.atlassian.com/kb/how-to-create-an-unproxied-application-link-719095740.html Contains spec tests, documentation and examples.
antaflos
force-pushed
the
additional_connectors
branch
from
566cb61
to
52e1796
Compare
|
Dear @antaflos, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Closing and reopening to trigger Travis, maybe the test failures unrelated to this change are now fixed. |
|
The checks now pass so if the PR could be merged, that'd be great :) |
|
thanks for the work! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Oct 13, 2021
Allow defining additional Tomcat connectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add a new, optional class parameter
jira::tomcat_additional_connectorswhose value is a well-formed, complex hash as described by the new type
aliases
Jira::Tomcat_connectorsandJira::Tomcat_attributes. Eachhash key represents a port number, and the key's value is a hash that
describes the connector's attributes and their values.
Useful for defining additional HTTP ports through which to access Jira.
A typical use case is when Jira and Confluence run behind a reverse
proxy and application links between Jira and Confluence must be set up.
Then it is often better to allow Jira and Confluence to communicate
directly instead of through the reverse proxy, but this requires a
Tomcat connector that is configured for direct access instead of reverse
proxy access (
proxyName,proxyPort, etc). Described here:https://confluence.atlassian.com/kb/how-to-create-an-unproxied-application-link-719095740.html
Contains spec tests, documentation and examples.