Update jira::facts to check for Puppet AIO agent #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
May 31, 2020
Comment on lines
32
to
34
| if $facts['puppetversion'] =~ /Puppet Enterprise/ { | ||
| $ruby_bin = '/opt/puppet/bin/ruby' | ||
| $dir = 'puppetlabs/' |
There was a problem hiding this comment.
I think this part is redundant now, assuming the other comment is correct.
There was a problem hiding this comment.
I don't have Puppet Enterprise to be able to test it to know for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Updates
jira::factsto check for the OSS version of the Puppet AIO agent. If the OSS Puppet AIO agent is installed it will setfacts.rbto use the version of ruby that comes with the AIO agent.This Pull Request (PR) fixes the following issues
Fixes #151