modulesync 4.0.0 #334

bastelfreak · 2020-11-25T16:23:50Z

modulesync 4.0.0

ekohl

EL6 failed:

       	**********     Wrong JVM version! You are running with java version "1.7.0_261" but JIRA requires at least 1.8 to run.      **********

Previously it didn't run and I'm not sure if Java 8 is available on EL6. Since it's going EOL I'm recommending to drop EL6.

ekohl

It should also drop .sync.yml which is now redundant.

ekohl · 2020-12-29T14:51:11Z

Not sure why PostgreSQL doesn't start on Ubuntu 16.04. It may be due to PIDFIle. #326 also broke Ubuntu due to bashisms. The next failure on Ubuntu 18.04 is that it doesn't recognize openjdk 11. Looks like the default version doesn't support that but recent ones do.

For now I'm giving up on this and someone who actually uses the module needs to step in.

kenyon · 2021-02-14T08:06:52Z

Not sure why PostgreSQL doesn't start on Ubuntu 16.04. It may be due to PIDFIle. #326 also broke Ubuntu due to bashisms. The next failure on Ubuntu 18.04 is that it doesn't recognize openjdk 11. Looks like the default version doesn't support that but recent ones do.

For now I'm giving up on this and someone who actually uses the module needs to step in.

This is the only remaining issue preventing the tests from passing. PostgreSQL on Ubuntu 16.04 starts but systemd hangs at "activating":

root@ubuntu1604-64-1:~# systemctl status postgresql@9.5-main
● postgresql@9.5-main.service - PostgreSQL Cluster 9.5-main
   Loaded: loaded (/lib/systemd/system/postgresql@.service; disabled; vendor preset: enabled)
   Active: activating (start) since Sun 2021-02-14 07:56:53 UTC; 37s ago
  Process: 6281 ExecStart=/usr/bin/pg_ctlcluster --skip-systemctl-redirect %i start (code=exited, status=0/SUCCESS)
   CGroup: /docker/378b796a749da8c903ba5f6f2da85ecf2ebd218038129f71e9f39a1c084d1d9a/system.slice/system-postgresql.slice/postgresql@9.5-main.service
           ├─6286 /usr/lib/postgresql/9.5/bin/postgres -D /var/lib/postgresql/9.5/main -c config_file=/etc/postgresql/9.5/main/postgresql.conf
           ├─6288 postgres: 9.5/main: checkpointer process
           ├─6289 postgres: 9.5/main: writer process
           ├─6290 postgres: 9.5/main: wal writer process
           ├─6291 postgres: 9.5/main: autovacuum launcher process
           └─6292 postgres: 9.5/main: stats collector process

Feb 14 07:56:53 ubuntu1604-64-1 systemd[1]: Starting PostgreSQL Cluster 9.5-main...
Feb 14 07:56:55 ubuntu1604-64-1 systemd[1]: postgresql@9.5-main.service: New main PID 6286 does not belong to service, and PID file is not owned by root. Refusing.
Feb 14 07:56:55 ubuntu1604-64-1 systemd[1]: postgresql@9.5-main.service: New main PID 6286 does not belong to service, and PID file is not owned by root. Refusing.

root@ubuntu1604-64-1:~# ll /run/postgresql/9.5-main.pid
-rw-r--r-- 1 postgres postgres 5 Feb 14 07:56 /run/postgresql/9.5-main.pid

root@ubuntu1604-64-1:~# cat /run/postgresql/9.5-main.pid
6286

🤷

Seems to be related to these:

Same problem here: voxpupuli/puppet-puppetboard#292

ekohl · 2021-02-14T11:09:17Z

We have a pidfile workaround in our templates which uses an older version of Ubuntu 16.04 but I'd prefer to drop Ubuntu 16.04. It's going EOL soon anyway.

Ubuntu 16.04 standard support ends in a few weeks. Including Ubuntu 16.04 support causes our acceptance tests to hang. See #334 (comment) for details. Also update some versions in the README.

ekohl · 2021-02-23T14:31:28Z

This is green, but care should be taken. #345 is included and I've included an alternative to #341 as well.

bastelfreak

I can't approve it, but looks good to me.

ekohl · 2021-02-23T15:08:21Z

@kenyon thoughts?

Closes #341

By specifying the dependencies on the resources, the chain is simpler. This allows Java to be installed even if PostgreSQL fails. The benefit is that it's easier to see in one go if things fail.

1112c0a changed the file to use bashisms, but on Ubuntu /bin/sh is dash, not bash. [[ is not supported.

These JVM args are unrecognized on CentOS 7 and cause Jira to fail to start.

Ubuntu 16.04 standard support ends in a few weeks. Including Ubuntu 16.04 support causes our acceptance tests to hang. See #334 (comment) for details. Also update some versions in the README.

kenyon · 2021-03-01T07:04:31Z

Looks good to me. Rebased on current master. Updated the Jira version in the alternative commit to #341.

ekohl

Let's get this in. I opened #346 for the Ubuntu 16.04 -> 18.04 change for the changelog.

Ubuntu 16.04 standard support ends in a few weeks. Including Ubuntu 16.04 support causes our acceptance tests to hang. See voxpupuli#334 (comment) for details. Also update some versions in the README.

bastelfreak added the modulesync label Nov 25, 2020

ekohl requested changes Nov 25, 2020

View reviewed changes

ekohl added the tests-fail label Nov 26, 2020

bastelfreak force-pushed the modulesync branch from 013dbe6 to 1f6def3 Compare December 14, 2020 09:46

bastelfreak removed the tests-fail label Dec 14, 2020

ekohl requested changes Dec 14, 2020

View reviewed changes

bastelfreak force-pushed the modulesync branch from 1f6def3 to f6bfad7 Compare December 14, 2020 12:12

ekohl approved these changes Dec 14, 2020

View reviewed changes

ekohl force-pushed the modulesync branch from 14e8402 to 66e3113 Compare December 29, 2020 13:39

ekohl mentioned this pull request Dec 29, 2020

Make JVM_EXTRA_ARGS manageable for java 11 compatibility #326

Merged

ekohl added the tests-fail label Dec 29, 2020

kenyon force-pushed the modulesync branch 2 times, most recently from e658ae7 to 924de44 Compare February 14, 2021 06:31

kenyon force-pushed the modulesync branch from 549bf8f to ef57207 Compare February 15, 2021 20:55

ekohl force-pushed the modulesync branch from ef57207 to f5cc3e7 Compare February 22, 2021 16:21

ekohl mentioned this pull request Feb 22, 2021

Adapting templates to state of 8.7.1 tarball, while keeping required … #329

Closed

ekohl removed the tests-fail label Feb 22, 2021

ekohl force-pushed the modulesync branch from f5cc3e7 to 017ed15 Compare February 23, 2021 10:27

ekohl force-pushed the modulesync branch from 017ed15 to 9e3e521 Compare February 23, 2021 10:35

bastelfreak commented Feb 23, 2021

View reviewed changes

ekohl and others added 7 commits February 28, 2021 22:29

Update default version to 8.13.4 and use openjdk-11

496b9d8

Closes #341

modulesync 4.0.0

f570819

Add Ubuntu 18.04 support

38eebac

Localize depenencies in acceptance tests

40de2c3

By specifying the dependencies on the resources, the chain is simpler. This allows Java to be installed even if PostgreSQL fails. The benefit is that it's easier to see in one go if things fail.

Remove bashisms from setenv.sh

5062965

1112c0a changed the file to use bashisms, but on Ubuntu /bin/sh is dash, not bash. [[ is not supported.

templates/setenv.sh.erb: remove bad JVM_EXTRA_ARGS

dcb0481

These JVM args are unrecognized on CentOS 7 and cause Jira to fail to start.

drop Ubuntu 16.04 support

7c0b69f

Ubuntu 16.04 standard support ends in a few weeks. Including Ubuntu 16.04 support causes our acceptance tests to hang. See #334 (comment) for details. Also update some versions in the README.

kenyon force-pushed the modulesync branch from 9e3e521 to 7c0b69f Compare March 1, 2021 06:29

kenyon mentioned this pull request Mar 1, 2021

acceptance tests: update Jira version to current LTS release, 8.13.4 #341

Closed

ekohl linked an issue Mar 1, 2021 that may be closed by this pull request

Drop Ubuntu 16.04, Add 18.04 instead #346

Closed

ekohl approved these changes Mar 1, 2021

View reviewed changes

ekohl merged commit 73eae4e into master Mar 1, 2021

ekohl deleted the modulesync branch March 1, 2021 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modulesync 4.0.0 #334

modulesync 4.0.0 #334

bastelfreak commented Nov 25, 2020

ekohl left a comment

ekohl left a comment

ekohl commented Dec 29, 2020

kenyon commented Feb 14, 2021 •

edited

Loading

ekohl commented Feb 14, 2021

ekohl commented Feb 23, 2021

bastelfreak left a comment

ekohl commented Feb 23, 2021

kenyon commented Mar 1, 2021

ekohl left a comment

modulesync 4.0.0 #334

modulesync 4.0.0 #334

Conversation

bastelfreak commented Nov 25, 2020

ekohl left a comment

Choose a reason for hiding this comment

ekohl left a comment

Choose a reason for hiding this comment

ekohl commented Dec 29, 2020

kenyon commented Feb 14, 2021 • edited Loading

ekohl commented Feb 14, 2021

ekohl commented Feb 23, 2021

bastelfreak left a comment

Choose a reason for hiding this comment

ekohl commented Feb 23, 2021

kenyon commented Mar 1, 2021

ekohl left a comment

Choose a reason for hiding this comment

kenyon commented Feb 14, 2021 •

edited

Loading