Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests after sysvinit patch broke them #345

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 23, 2021

Fixes: 23242f9

Now I do notice that my patch ends up moving the .service file on Debian-based OSes from /lib/systemd to /usr/lib/systemd. It was marked as a backwards incompatible change but it may still surprise users. Thoughts?

On Debian-based distros /usr/lib/systemd doesn't exist while on Red Hat
7+ /lib is a symlink to /usr/lib. That means using /lib/systemd works on
all supported distros.

Fixes: 23242f9
@@ -5,7 +5,7 @@
class jira::params {
Exec { path => ['/bin/', '/sbin/', '/usr/bin/', '/usr/sbin/'] }

$service_file_location = '/usr/lib/systemd/system/jira.service'
$service_file_location = '/lib/systemd/system/jira.service'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we put it into /etc/systemd/system?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind that, but it does mean a migration. This was the easiest fix to the regression I introduced.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, fine by me as a short term fix

@ekohl ekohl mentioned this pull request Feb 23, 2021
@ekohl ekohl merged commit cf77fbc into voxpupuli:master Feb 23, 2021
@ekohl ekohl deleted the fix-tests branch February 23, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants