Updating check-java.sh and server.xml templates to upstream version #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
reviewed
Mar 1, 2021
kenyon
approved these changes
Mar 1, 2021
ekohl
reviewed
Mar 2, 2021
|
The tests are failing. Could you have a look? |
|
Will do (probably on weekend), didn't find the time yet, sorry. |
|
@ekohl PR is now updated |
|
Can you clean up the commit history (get rid of merge commit, combine fixup commits)? Or set the PR to allow edits by maintainers so we can do it. |
|
Also note that your kps email address is not registered with your GitHub account. |
timdeluxe
force-pushed
the
feature/update-check-java-and-server-xml-templates
branch
from
d0b5777
to
574ce40
Compare
|
@kenyon Thanks for the hints. Hope i won my fight against git rebase successfully now... (i am always fighting with it) |
ekohl
approved these changes
Mar 17, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Oct 13, 2021
…ava-and-server-xml-templates Updating check-java.sh and server.xml templates to upstream version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Updates check-java.sh and server.xml templates to upstream version. Especially the check-java update is required, when using a java version > 8 (or 1.8, depending which versioning scheme you look at.
This Pull Request (PR) fixes the following issues
Fixes #339
Kind of fixes #300
This replaces PR #317.