Refactor database configuration and make the main API typed #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranenj
force-pushed
the
refactor-dbconfig
branch
from
87be51b
to
22d7269
Compare
|
Squashed and reworded a bit |
oranenj
changed the title
oranenj
changed the title
bastelfreak
approved these changes
Apr 13, 2021
This removes the use_connection_pooling parameter since for most databases, it does nothing useful. It also sets most parameters to "undef" and omits them from the configuration if the user doesn't override them. The previous module defaults mostly match JIRA's built-in ones anyway.
oranenj
force-pushed
the
refactor-dbconfig
branch
from
a9668df
to
5f0e931
Compare
|
Needs another review, the changes are a bit more drastic now. Basically, set defaults for ~everything to undef and omit them from dbconfig.xml unless specified by the user. Also removes pool-size, I don't think it does anything, since it's not documented by Atlassian. |
oranenj
force-pushed
the
refactor-dbconfig
branch
from
0062649
to
4f16e9f
Compare
ekohl
approved these changes
Apr 13, 2021
oranenj
changed the title
oranenj
force-pushed
the
refactor-dbconfig
branch
from
26e9e7d
to
09aaa81
Compare
oranenj
changed the title
oranenj
force-pushed
the
refactor-dbconfig
branch
from
d298839
to
dfe1467
Compare
|
I've also tested this on the Jira instance I have available and it doesn't break anything obvious, so I'll squash-merge. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Oct 13, 2021
…i#352) Unify dbconfig.xml across databases and use JIRA's built-in defaults when not overridden by user This removes the use_connection_pooling parameter since for most databases, it does nothing useful. The poolsize parameter is also deprecated, and is just an alias for pool_max_size now It also sets the default values for most parameters to "undef" and omits them from the configuration if the user doesn't override them. The previous module defaults mostly match JIRA's built-in ones anyway. While here, add types to the main API; some things which accepted integer-looking strings previously will now require actual integers, but otherwise nothing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors DB configuration to use a single template.
Changes PostgreSQL defaults a bit, but I'm pretty sure the default was ineffective anyway, so this is half of an API break...