Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use puppet-kmod to manage kernel_modules #15

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Use puppet-kmod to manage kernel_modules #15

merged 1 commit into from
Mar 7, 2023

Conversation

SimonHoenscheid
Copy link
Sponsor Member

Fixes #8

@SimonHoenscheid SimonHoenscheid mentioned this pull request Mar 1, 2023
Merged
ananace
ananace reviewed Mar 2, 2023
View reviewed changes
manifests/node/kubelet.pp Outdated Show resolved Hide resolved
bastelfreak
bastelfreak reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add a unit test and add the module to .fixtures.yml

@SimonHoenscheid SimonHoenscheid force-pushed the shoenscheid_kmod branch 3 times, most recently from bb6d277 to 19625bb Compare March 6, 2023 22:06
@SimonHoenscheid SimonHoenscheid merged commit 15ebe8d into voxpupuli:master Mar 7, 2023
@SimonHoenscheid SimonHoenscheid deleted the shoenscheid_kmod branch March 7, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananace ananace ananace approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak

@kenyon kenyon Awaiting requested review from kenyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[improvement] Use puppet-kmod module to handle Kernel modules
4 participants
@SimonHoenscheid @kenyon @bastelfreak @ananace