Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MirrorMaker abort.on.send.failure #97

Merged

Conversation

SegFaultAX
Copy link
Contributor

@SegFaultAX SegFaultAX commented Aug 24, 2016

Per KIP-3, --abort.on.send.failure=false prevents Kafka MirrorMaker from immediately aborting when it's unable to send to the output cluster.

@travees
Copy link
Contributor

travees commented Aug 25, 2016

👍

@fessyfoo
Copy link
Contributor

👍 are we (opentable) still considered committers on this project? @liamjbennett?? :) all of FKA-Owners are admins on this still but non of us but liam have ever talked with voxpupli folk.

@liamjbennett
Copy link
Member

@fessyfoo yes you are committers on this project. You can reach me on the usual channels if you'd like better introductions to the other voxpupli folk.

@SegFaultAX
Copy link
Contributor Author

@liamjbennett Thanks! I think it would be great to have a few people (at least Fess and myself) in Vox. What's the process for making that a reality? Also, who is responsible for releasing new versions of this particular project to the forge?

@fessyfoo @travees I guess that means we should feel confident in merging this when we think it's ready (which is to say, now).

@fessyfoo
Copy link
Contributor

@liamjbennett any vox guidelines we should read?

@fessyfoo fessyfoo merged commit e999402 into voxpupuli:master Aug 26, 2016
@SegFaultAX SegFaultAX deleted the kafka-mirrormaker-abortonfailure branch August 26, 2016 18:37
elmendalerenda pushed a commit to elmendalerenda/puppet-kafka that referenced this pull request Mar 30, 2018
…rtonfailure

Add support for MirrorMaker abort.on.send.failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants