Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hiera yaml to version 5 #36

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Jan 11, 2019

Pull request acceptance prerequisites:

  • Signed the CLA (if not already signed)
  • Rebased/up-to-date with base branch
  • Updated CHANGELOG.md with patch notes (if necessary)
  • Any relevant docs (README.markdown or inline documentation) updated (if necessary)
  • Updated CONTRIBUTORS (if you would like attribution)
  • Tests pass CI

@tylerjl
Copy link
Contributor

tylerjl commented Jan 14, 2019

Thanks for the PR @mmoll - do you happen to have a link to the Puppet support lifecycle? I'm on board with bumping the minimum required Puppet version if versions < 4.9 are end-of-life (but I can't find documentation about it anywhere)

@mmoll
Copy link
Contributor Author

mmoll commented Jan 14, 2019

@tylerjl Unfortunately there seem to be no notes about this, but https://ask.puppet.com/question/33472/puppet-4-open-source-end-of-life-eol/ and https://groups.google.com/forum/#!topic/puppet-users/78ZcVVyuIMQ suggests that even the whole 4.x series is EOL now. However, the 4.10.x branch in Puppetlabs' repo seems still to get updates, (which is still > 4.9).

@tylerjl
Copy link
Contributor

tylerjl commented Jan 14, 2019

Alright @mmoll I hopped into the Puppet community Slack and talked with a product manager and 4.x is dead after the start of 2019, but I don't see a reason to kill 4.x entirely yet - but at the very least moving a version that shipped Hiera 5 sounds reasonable. They suggested supporting >= 4.10 since that's a much more recently-supported version of 4.x, so if you're in agreement, could I ask:

  1. Bump the minimum version (and associated tests) to point at 4.10 instead of 4.9, since it sounds like 4.10 is the way to go
  2. Make a small note about raising the minimum required Puppet version in the module's CHANGELOG
  3. Do the same for the puppet-elasticsearch module PR (Update hiera yaml to version 5 puppet-elasticsearch#1010)?

Thanks for taking the initiative on version bumping here, community help is greatly appreciated 🙏

@tylerjl
Copy link
Contributor

tylerjl commented Jan 14, 2019

Also side-note (that I'm sure you already discerned), the failing Travis test is unrelated so with the changes I mentioned above I'm happy to merge this.

@mmoll
Copy link
Contributor Author

mmoll commented Jan 14, 2019

@tylerjl Sure, what's the next version for the changelog? 6.3.2? 6.4.0? 7.0.0? :)

@mmoll
Copy link
Contributor Author

mmoll commented Jan 14, 2019

aw, sorry, ignore the qestion, I see the placeholder now

@mmoll
Copy link
Contributor Author

mmoll commented Jan 14, 2019

done. :bowtie:

@tylerjl
Copy link
Contributor

tylerjl commented Jan 15, 2019

Thanks a million @mmoll 🙏

@tylerjl tylerjl added this to the Next Release milestone Jan 15, 2019
@tylerjl tylerjl merged commit 154284f into voxpupuli:master Jan 15, 2019
@mmoll mmoll deleted the hiera5 branch January 15, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants