Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove template erb and puppet_x folder #72

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Remove template erb and puppet_x folder #72

merged 1 commit into from
Feb 7, 2023

Conversation

phaedriel
Copy link

@phaedriel phaedriel commented Jan 27, 2023 •
edited
Loading

Pull Request (PR) description

  • Replace template erb by function ruby. the template required 'puppet_x/elastic/hash'
  • Remove folders 'puppet_x'

This Pull Request (PR) fixes the following issues

  • I tried to install kibana 8.6.0 and my hiera value
    (logger) level = off is converted in false value in kibana.yaml (and service kibana don't start)

@phaedriel phaedriel changed the title Remove template erb (with puppet-elasticsearch link) Remove template erb (need module puppet-elasticsearch) Jan 27, 2023
@phaedriel phaedriel changed the title Remove template erb (need module puppet-elasticsearch) Remove template erb and module puppet-elasticsearch link Jan 27, 2023
@phaedriel phaedriel closed this Jan 27, 2023
@phaedriel phaedriel reopened this Jan 27, 2023
@phaedriel phaedriel changed the title Remove template erb and module puppet-elasticsearch link Remove template erb and puppet_x folder Jan 27, 2023
@bastelfreak bastelfreak added enhancement New feature or request tests-fail labels Jan 27, 2023
@phaedriel phaedriel changed the title Remove template erb and puppet_x folder Draft: Remove template erb and puppet_x folder Jan 27, 2023
smortex
smortex approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex marked this pull request as draft February 7, 2023 06:28
@smortex
Copy link
Member

smortex commented Feb 7, 2023

Just realized the PR title started with "Draft" so I switched this PR to draft mode. Please turn click on "Ready for review" when you consider this done. Thanks!

@phaedriel phaedriel changed the title Draft: Remove template erb and puppet_x folder Remove template erb and puppet_x folder Feb 7, 2023
@phaedriel phaedriel marked this pull request as ready for review February 7, 2023 17:15
@smortex smortex merged commit 658e842 into voxpupuli:master Feb 7, 2023
@smortex smortex mentioned this pull request Feb 7, 2023
Merged
@phaedriel phaedriel deleted the remove_template branch February 8, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phaedriel @smortex @bastelfreak @stjmt