use puppet strings #203
Closed
use puppet strings #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dan33l
force-pushed
the
use-puppet-strings
branch
2 times, most recently
from
9b683f9 to
31a612d
Compare
bastelfreak
reviewed
Oct 3, 2019
manifests/hook.pp
Outdated
| # | ||
| define letsencrypt::hook ( | ||
| Enum['pre', 'post', 'deploy'] $type, | ||
| String[1] $hook_file, | ||
| # hook.sh.epp will validate this | ||
| $commands, | ||
| Variant[String,Array[String]] $commands, |
There was a problem hiding this comment.
Suggested change
| Variant[String,Array[String]] $commands, | |
| Variant[String[1],Array[String[1]]] $commands, |
|
Tests are failing because of rspec/rspec-expectations#1134 |
Dan33l
force-pushed
the
use-puppet-strings
branch
from
31a612d to
ca86dc1
Compare
|
Closed because gems are cached. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR is a first step to use puppet strings.
A second second PR will be done after this one is merged. This will permit to switch from params.pp to common values in init.pp and OS specific values in hiera data of module. We will have auto generated default values in doc for common values.
By this way it split doc modification and code modification into dedicated PR.
This Pull Request (PR) fixes the following issues