Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid handling of heredoc strings #10

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Fix invalid handling of heredoc strings #10

merged 1 commit into from
Sep 26, 2018

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Sep 16, 2018

This fixes issue #8

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Could you fix the small nit?

@seanmil
Copy link
Contributor Author

seanmil commented Sep 26, 2018

Are there any other questions / issues on this PR that I should address to get this merged?

Also, any idea when the next release might be?

Thanks!

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you just caught me right before my vacation :) I don't know about a specific plan to release - usually they're done when someone feels sufficient changes have been merged. This number can be 1.

@ekohl ekohl merged commit 04e4678 into voxpupuli:master Sep 26, 2018
@ekohl
Copy link
Member

ekohl commented Sep 26, 2018

Thanks! For future reference: if you format it Fixes #8 then it automatically closes the issue when it's merged.

@ekohl
Copy link
Member

ekohl commented Sep 26, 2018

@seanmil there's currently one issue open. I don't know if it's actually still relevant. I'd be awesome if you could find out and implement a fix if needed. After that I'll find the time to do a release.

@seanmil
Copy link
Contributor Author

seanmil commented Sep 26, 2018

I looked at that issue, I believe it will take a bit of work to implement but I think I can do it and figured I'd give it a shot when I had time. However, I probably won't be able to get to it for a little while, so I'll just build and release an internal gem for this in the interim (as this bug is actively causing me some CI pain points). Thanks!

@bodgit
Copy link

bodgit commented Sep 26, 2018

+1 for a release if possible

@seanmil seanmil mentioned this pull request Oct 20, 2018
@ekohl ekohl linked an issue Oct 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid handling of heredoc strings
3 participants