-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid handling of heredoc strings #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct. Could you fix the small nit?
spec/puppet-lint/plugins/check_trailing_comma/check_trailing_comma_spec.rb
Show resolved
Hide resolved
Are there any other questions / issues on this PR that I should address to get this merged? Also, any idea when the next release might be? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you just caught me right before my vacation :) I don't know about a specific plan to release - usually they're done when someone feels sufficient changes have been merged. This number can be 1.
Thanks! For future reference: if you format it |
@seanmil there's currently one issue open. I don't know if it's actually still relevant. I'd be awesome if you could find out and implement a fix if needed. After that I'll find the time to do a release. |
I looked at that issue, I believe it will take a bit of work to implement but I think I can do it and figured I'd give it a shot when I had time. However, I probably won't be able to get to it for a little while, so I'll just build and release an internal gem for this in the interim (as this bug is actively causing me some CI pain points). Thanks! |
+1 for a release if possible |
This fixes issue #8