Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heredoc handling. Add support for interpolated heredocs. #15

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Oct 22, 2018

This should resolve #14 and possibly fix other heredoc-related bugs.

@seanmil seanmil mentioned this pull request Oct 22, 2018
@genebean
Copy link

genebean commented Oct 24, 2018

This seems to resolve the errors I was seeing related to #14 after #12. Now when I run bundle exec puppet-lint site dist site.pp --fix --only-checks trailing_comma and follow it up with bundle exec rake syntax I don't get errors related to heredoc's. For reference, I tested this by setting the following in my Gemfile:

gem 'puppet-lint-trailing_comma-check', git: 'https://github.com/seanmil/puppet-lint-trailing_comma-check.git', branch: 'fix_interpolated_heredocs'

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanmil for the patch and @genebean for testing!

@ekohl ekohl merged commit fe0892f into voxpupuli:master Oct 24, 2018
@ekohl
Copy link
Member

ekohl commented Oct 24, 2018

https://github.com/voxpupuli/puppet-lint-trailing_comma-check/releases/tag/0.4.1

@ekohl ekohl linked an issue Oct 1, 2022 that may be closed by this pull request
@ekohl ekohl added the bug label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpolated heredocs not detected correctly Breaks heredocs
3 participants