Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a HEREDOC example #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

traylenator
Copy link

@traylenator traylenator commented Jun 4, 2024

When the last parameter is a HEREDOC the solution to this linter is really not obvious.

Add an explicit example.

When the last parameter is HEREDOC the solution to this linter
is really not obvious.

Add an explicit example.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this, should we make an exception for heredoc? The trailing comma has the benefit that when you add a line the existing last line isn't modified. With heredoc I don't think that's true. Or is it?

@kenyon
Copy link
Member

kenyon commented Jun 4, 2024

@ekohl the trailing comma rule still applies with heredocs, the comma is just not on the literal last line, it's on the line of the heredoc identifier.

@ekohl
Copy link
Member

ekohl commented Jun 4, 2024

Good to know. Thanks!

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI need love but it is probably for another PR.

The REAME change is good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants