Drop support for ruby < 2.0.0. Update badges for voxpupuli #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
voxpupuli
branch
3 times, most recently
from
828107f
to
9e2cc53
Compare
|
why do we even test on those legacy ruby version? Can't we just drop them? |
|
@bastelfreak Maybe. I thought matching puppet-lint's testing matrix would be an ok starting point. There can't be many OSes where ruby < 2. And when developing, there's really no reason you couldn't just install rvm. |
|
I guess I'd also like to understand why the pinning of tins doesn't work on travis. It works for me locally. |
alexjfisher
force-pushed
the
voxpupuli
branch
2 times, most recently
from
c2a4306
to
12a1729
Compare
|
I'm not actually sure it makes sense trying to specify different dependencies depending on the version of ruby. So I've dropped everything < 2.0. |
alexjfisher
changed the title
Testing against older versions is becoming increasingly difficult. Also update badges for voxpupuli.
alexjfisher
force-pushed
the
voxpupuli
branch
from
12a1729
to
dc466a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove ruby 1.8 dev support.