mongodb no longer provides the stable link #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunner
requested changes
Mar 30, 2017
manifests/repo.pp
Outdated
| @@ -13,7 +13,8 @@ | |||
| $location = $repo_location | |||
| $description = 'MongoDB Custom Repository' | |||
| } elsif $mongodb::globals::use_enterprise_repo == true { | |||
| $location = 'https://repo.mongodb.com/yum/redhat/$releasever/mongodb-enterprise/stable/$basearch/' | |||
| $mongover = split($version, '[.]') | |||
There was a problem hiding this comment.
Version defaults to undef so perhaps we should raise an error if it is not set, as use_enterprise_repo requires it?
There was a problem hiding this comment.
its used for all redhat family repos, not just enterprise. In the foss part of the decision tree, there is simple check if $version is set. I could add the same code to the enterprise check.
There was a problem hiding this comment.
You could add the check to globals, or here. Something like
if $use_enterprise_repo == true and $version == undef {
fail('You must set mongodb::globals::version when mongodb::globals::use_enterprise_repo is true')
}…h means version needs to be set, moved the version split out of if tree to prevent code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we need to link directly to the appropriate version dir, fixed it similar as the no enterprise version