Fix a circular loading issue with mongodb::repo #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jun 25, 2018
manifests/repo.pp
Outdated
| $ensure = $mongodb::params::ensure, | ||
| $version = $mongodb::params::version, | ||
| Variant[Enum['present', 'absent'], Boolean] $ensure = 'present', | ||
| Optional[String] $version = undef, | ||
| $repo_location = undef, | ||
| $proxy = undef, | ||
| $proxy_username = undef, | ||
| $proxy_password = undef, |
There was a problem hiding this comment.
can you please align the = please?
There was a problem hiding this comment.
Should we align or remove all alignment? With puppet data types I think alignment makes it harder to read.
mongodb::globals includes mongodb::repo mongodb::repo inherits from mongodb::params mongodb::params inherits from globals We work around this by removing the inheritance from mongodb::repo and requiring explicit parameters. We then pass in the parameters explicitly in mongodb::globals. Since repo is a private class this shouldn't be considered breaking an API. While we're at it we add types to the parameters we change. Fixes voxpupuli#428
Rather than disabling it, we should actually remove it. This is cleaner.
|
Updated with another commit added to only use local vars in |
|
I have these changes running and can confirm the repo management works. |
|
What is blocking this? |
|
@bastelfreak could you re-review this? |
|
thanks for the patch @ekohl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongodb::globals includes mongodb::repo mongodb::repo inherits from
mongodb::params mongodb::params inherits from globals
We work around this by removing the inheritance from mongodb::repo and
requiring explicit parameters. We then pass in the parameters explicitly in
mongodb::globals. Since repo is a private class this shouldn't be
considered breaking an API. While we're at it we add types to the
parameters we change.
Fixes #428
Also ensures the yumrepo is absent rather than disabled.