-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gha pidfile_workaround #705
Remove gha pidfile_workaround #705
Conversation
Have to figure out if its possible to remove the pidfile workaround from modulesync for this module ... Have to verify that this is the right way |
13edabb
to
5c28745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing new-line at end-of-file in .sync.yml
.
For details, see for example:
https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file
Check your editor config to avoid having to deal with this by hand. This should be the default settings, but some editors sucks 😒.
@smortex there is a newline at the end
|
The file in master is missing newline at the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it's the missing \n that is "removed" (so added) 🙃
LGTM!
Pull Request (PR) description
The latest releases of mongodb does not declare PIDfile in the service files.