Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gha pidfile_workaround #705

Merged

Conversation

h-haaks
Copy link
Contributor

@h-haaks h-haaks commented Mar 19, 2024

Pull Request (PR) description

The latest releases of mongodb does not declare PIDfile in the service files.

@h-haaks h-haaks marked this pull request as draft March 19, 2024 00:48
@h-haaks
Copy link
Contributor Author

h-haaks commented Mar 19, 2024

Have to figure out if its possible to remove the pidfile workaround from modulesync for this module ...
Edit: Solved by removing from .sync.yml as well.

Have to verify that this is the right way

@h-haaks h-haaks force-pushed the remove-gha-pidfile_workaround branch from 13edabb to 5c28745 Compare March 19, 2024 01:04
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new-line at end-of-file in .sync.yml.

For details, see for example:
https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file

Check your editor config to avoid having to deal with this by hand. This should be the default settings, but some editors sucks 😒.

@h-haaks
Copy link
Contributor Author

h-haaks commented Mar 19, 2024

@smortex there is a newline at the end

[vagrant@ruby-dev-env puppet-mongodb]$ cat .sync.yml .sync.yml 
---
appveyor.yml:
  delete: true
---
appveyor.yml:
  delete: true

@h-haaks h-haaks marked this pull request as ready for review March 19, 2024 06:59
@h-haaks
Copy link
Contributor Author

h-haaks commented Mar 19, 2024

The file in master is missing newline at the end.

@h-haaks h-haaks requested a review from smortex March 19, 2024 07:03
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's the missing \n that is "removed" (so added) 🙃

LGTM!

@h-haaks h-haaks merged commit e5b56da into voxpupuli:master Mar 19, 2024
12 checks passed
@h-haaks h-haaks deleted the remove-gha-pidfile_workaround branch March 19, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants