Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Suse enterprise repository #719

Merged

Conversation

h-haaks
Copy link
Contributor

@h-haaks h-haaks commented Mar 24, 2024

Pull Request (PR) description

Adding support for Suse enterprise repository

} else {
$_repo_location = "https://repo.mongodb.org/zypper/suse/\$releasever_major/mongodb-org/${version}/\$basearch/"
$description = 'MongoDB Repository'
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have tesing on Suse but the enterprise repo is there so I guess it's ok to add it.

@h-haaks
Copy link
Contributor Author

h-haaks commented Mar 25, 2024

Should we add opensuse to metadata to get it tested?

Copy link
Contributor

@stevenpost stevenpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see these moved to module data, so code gets a lot simpler, I was thinking of having 2 parameters, 1 for the community edition and one for the enterprise edition.

That can go in a follow-up PR.

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 3, 2024

Should we add opensuse to metadata to get it tested?

Tried to run beaker with opensuse15-64 and docker but it seems like beaker-docker is still using the old and deprecated amd64/opensuse/leap images ...

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 3, 2024

I would like to see these moved to module data, so code gets a lot simpler, I was thinking of having 2 parameters, 1 for the community edition and one for the enterprise edition.

Do you mean two repo location params? Thats a bit odd if the class should only manage one repo.

@h-haaks h-haaks merged commit fa0db53 into voxpupuli:master Apr 3, 2024
24 checks passed
@h-haaks h-haaks deleted the support-suse-enterprise-repo branch April 3, 2024 06:41
@stevenpost
Copy link
Contributor

stevenpost commented Apr 3, 2024

I would like to see these moved to module data, so code gets a lot simpler, I was thinking of having 2 parameters, 1 for the community edition and one for the enterprise edition.

Do you mean two repo location params? Thats a bit odd if the class should only manage one repo.

Yes, then the code can do something like:

$_real_repo = $use_enterprise_repo ? {
  true    => $community_repo,
  default => $enterprise_repo,
}

If going with a single parameter, it needs to be undef by default and we end up with a huge select for the OS as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants