Use proper yaml for the mongod config #740
Conversation
|
@stevenpost This is just a start with 'systemLog' |
templates/mongodb.conf.erb
Outdated
| <% end -%> | ||
| <% if @system_logrotate -%> | ||
| systemLog.logRotate: <%= @system_logrotate %> | ||
| <% config_hash['systemLog']['logRotate'] = @system_logrotate -%> |
There was a problem hiding this comment.
The naming of existing params is kind of annoying.
Here the param name all of a sudden is prepended with 'system_' ...
templates/mongodb.conf.erb
Outdated
| <% elsif @verbositylevel == "vvvvv" -%> | ||
| systemLog.verbosity: 5 | ||
| <% config_hash['systemLog']['verbosity'] = 5 -%> |
There was a problem hiding this comment.
And here class params mimic mongosh -v, -vv options or something? ...
templates/mongodb.conf.erb
Outdated
| <% if @syslog -%> | ||
| systemLog.destination: syslog | ||
| <% config_hash['systemLog']['destination'] = 'syslog' -%> |
There was a problem hiding this comment.
syslog param sets destination to syslog, but there is no param to set syslogFacility ...
|
I do think this is the right way to move this. |
|
Cleaning up the params of mongodb::server should be done in a separate PR btw. |
h-haaks
force-pushed
the
real-yaml-in-mongod.conf
branch
from
fd4c664
to
75037b6
Compare
|
Requires #741 before converting net. settings to pure yaml. |
|
I restored my branch so you can take what you find useful. I think using |
h-haaks
force-pushed
the
real-yaml-in-mongod.conf
branch
4 times, most recently
from
3a34d30
to
06b713e
Compare
h-haaks
force-pushed
the
real-yaml-in-mongod.conf
branch
from
06b713e
to
14f6fc9
Compare
| <%- if !@nohttpinterface.nil? -%> | ||
| <%- if !config_hash['net']['http'] -%> | ||
| <%- config_hash['net']['http'] = {} -%> | ||
| <%- end -%> | ||
| <%- config_hash['net']['http']['enabled'] = !@nohttpinterface -%> | ||
| <%- end -%> |
There was a problem hiding this comment.
Probably for another PR, but I don't really like these no-prefixed options if the actual option is actually the reverse.
I would keep things more simple by dropping the 'no'.
Like Optional[boolean] $enable_http_interface = undef, but ok, that has nothing to do with this specific PR.
There was a problem hiding this comment.
Yeah I know. Just didn't want to drag that into this PR
.
No description provided.