Add support for AppStream package installation

[Henrik-Hansson]

Pull Request (PR) description

Add support to install nginx through AppStream on EL8.

This Pull Request (PR) fixes the following issues

[puppet-community-rangefinder]

nginx is a class

Breaking changes to this file WILL impact these 15 modules (exact match):

• samuelson-custom_webapp
• stackstorm-st2
• dhollinger-devopsdays
• jonhallettuob-existdb
• covata-safeshare
• puppet-hyperglass
• eelcomaljaars-friendica
• cristifalcas-kibana
• akisakye-matomo
• kalfa-sites
• othalla-nextcloud
• ploperations-webhook_proxy
• landcareresearch-ckan
• pgassmann-letsencrypt_nginx
• geoffwilliams-r_profile

Breaking changes to this file MAY impact these 34 modules (near match):

• ramiel-owncloud
• compass-learninglocker
• maestrodev-maestro_nodes
• tracywebtech-appdeploy
• puppetfinland-patchwork
• SchnWalter-happydev
• klynton-testing
• qroac-isp3node
• nicopaez-triage
• puppetfinland-freight
• compass-examdb
• nicopaez-alfred
• firm1-zds
• ploperations-puppet
• vormetriclabs-meteor
• vshn-uhosting
• danieldreier-puppet_installer
• qtechnologies-psgi
• jbussdieker-graphite_web
• 4n0m4l0u5-configure_nginx
• lboynton-gitlab
• jmkeyes-netbox
• nicopaez-dockerserver
• aursu-grayloginstall
• mtulio-profiles
• oris-appserver
• groupbuddies-gb
• mightp-librenms
• braiins-wordpressnginx
• dmexe-deploy
• chedi-django
• halyard-boxen
• pltraining-selfpaced
• adcade-statsd

nginx::package::redhat is a class

that may have no external impact to Forge modules.

This module is declared in 9 of 577 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[anders-larsson]

It seems this pull request needs additional work. Currently it attempts to install the "package" every time Puppet is executed.

[ekohl]

Maybe it helps, but in our Candlepin module we use enable_only => true: https://github.com/theforeman/puppet-candlepin/blob/27a0f4d4de5d2180309db05a508041d997139739/manifests/install.pp#L14-L21

I'm not sure if that can also switch modules and haven't looked at the details if I'm honest.

[ekohl]

Looks good to me. Let me know if you want to address my comment. Without it it's already a good change IMHO, but it can help other RHEL clones.

[ekohl]

Would it make sense to use os.family instead?

[Henrik-Hansson]

I agree that os.family seems better. I will rebase and update with os.family.

[ekohl]

Thanks!

[ekohl]

I think #1501 should fix the acceptance tests, except for EL7. But that shouldn't hold up this PR. Unit tests should suffice for that (but those are still running).

[Henrik-Hansson]

Hello, what can I do to get this merged?
The CI validation fails on something not related to this PR.
BR,
Henrik

[ekohl]

I've opened #1519 to fix that.

[ekohl]

Please rebase.

[Henrik-Hansson]

Hi, sorry for delay.
Most of the tests fails on passenger, don't think it's related to my change.
I have fixed the Package error I introduced with "Package['nginx']", with "'Package[nginx]'".

[ardrigh]

@kenyon is it possible for you to do a fresh review for this to get merged?

It appears the documentation has been added, and this is much needed improvement for RHEL servers.

[kenyon]

#1573 removes EOL Ubuntu 18.04.

[ardrigh]

@Henrik-Hansson if you are still keen to update this pull request, the version check could use a tweak.

RHEL9 started with 1.20, a version check for this should fix the tests.

It might be easier to assume a test for nginx 1.22 that is available in both RHEL8.8 and RHEL9.2 appstreams?