Remove legacy data types #1566
Merged
Remove legacy data types #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
remove-legacy-data-types
branch
from
f0bc7f1
to
a2b21c5
Compare
smortex
force-pushed
the
remove-legacy-data-types
branch
from
a2b21c5
to
722b124
Compare
These data types where kept for backwards compatibility, but are syntaxically incorrect. Remove them.
TheMeier
force-pushed
the
remove-legacy-data-types
branch
from
722b124
to
5bbe1e2
Compare
|
rebased |
|
@smortex what is missing, or is this ready for review? |
I think it is fine. I think I marked it as draft to avoid merging it too fast. but if we are ready for a new major version this is fine! |
TheMeier
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove backwards-compatible data types which where bogus.
It is intended to be rebased on top of master and merged when we want to cut a new major version and people had the time to update their code to not rely on these.