Allow for an outsider package on RHEL8+ #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
reviewed
Aug 14, 2024
TheMeier
reviewed
Aug 14, 2024
gcoxmoz
force-pushed
the
rhel8-packagenames
branch
from
89d839e
to
21dfe27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
openldap::server::config, if redhat 8-or-newer, there's asystemd::dropin_filethat makes a startup file so you can tune the user/usr/sbin/slapdruns as.The problem is, there's a subtle assumption here that your binary is actually
/usr/sbin/slapd. Ever since RHEL7.4, theopenldap-servershas been deprecated, so some of us have pivoted over to using Symas' packages, which installs everything in/opt. That is, Puppet says to use/usr/sbin/slapd"because you're on RHEL8" (wrong), instead of "because you're using a RHEL-styled package". So this makes it more explicit why you're using this file, and takes it away when you use a different package."Why not just symlink slapd?" Tried, didn't work. systemd was not pleased by this.
"Why not just make the fully-pathed slapd executable be a parameter which defaults to
/usr/sbin/slapd". Thought about it. But for the most part I'm thinking "this file adds unnecessary noise" so I went for the path of least surprise and removed it.