Autodetect supported instead of using Hiera #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Apr 22, 2021
bastelfreak
approved these changes
Apr 22, 2021
ekohl
commented
Apr 22, 2021
Previously it (ab)used Hiera to set the supported versions. This now uses metadata.json and facts to do the same. The parameter is kept in to override this. It is turned into undef to allow pick() and signal that the value is determined later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it (ab)used Hiera to set the supported versions. This now uses metadata.json and facts to do the same. The parameter is kept in to override this. It is turned into undef to allow pick() and signal that the value is determined later.