Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 11 and 12 to supported OS #74

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Valantin
Copy link
Contributor

Pull Request (PR) description

Add Debian 11 and 12 to supported OS

This Pull Request (PR) fixes the following issues

Copy link
Contributor

@TheMeier TheMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove 7,8,9... and maybe even 10?

@Valantin
Copy link
Contributor Author

My point is, remove all deprecated version in one PR, before that adding new version for all supported OS
I isn't the correct way, I do it all in one

@bastelfreak I probably misunderstood the suggested method?

@bastelfreak bastelfreak added the enhancement New feature or request label Mar 11, 2024
@bastelfreak
Copy link
Member

Adding support for a new OS, is an enhancement. Removing support is a backwards-incompatible change. And sometime we fix broken stuff, then it is a bug(fix). We use labels on or PRs to separate those three changes and try not to mix it. We've some more infos on https://voxpupuli.org/docs/reviewing_pr/.

Each label will be added to a different section of the CHANGELOG.md. Because of that we shouldn't mix it. And it makes potential rebases/cherry-picks and reverts easier if bugfixes/enhancements/backwards-incompatible changes easier.

I also think Debian 7,8,9,10 should be dropped, but in another PR.

@bastelfreak bastelfreak merged commit e4b711e into voxpupuli:master Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants