Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document parameter supported #83

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

Valantin
Copy link
Contributor

Pull Request (PR) description

Document the parameter supported to force the result of os check and install open-vm-tools on OS non in the list
this is useful in case of a release of new os not in the list of the currente relesed module

This Pull Request (PR) fixes the following issues

@Valantin Valantin added the docs Improvements or additions to documentation label Mar 18, 2024
README.markdown Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR: we should also change the OS Support section to refer to metadata.json.

Copy link
Contributor Author

@Valantin Valantin Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exist a way to use command like strings:generete:reference to dynamically update the section to reflect the metadata.json?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some modules have a generic "See metadata.json for supported platforms". I am not even sure that this make sense because when you see that on the puppet forge, the information is available on top of the module page and "metadata.json" is an implementation detail that may not make sense for the end user. Maybe just dropping these outdated lists of EOL operating systems is simpler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, do you prefere a differente PR or on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping is also fine by me. I think a separate PR for that is good.

@ekohl ekohl merged commit 90026ca into voxpupuli:master Mar 21, 2024
32 checks passed
@Valantin Valantin deleted the doc-supported branch March 29, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants