Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

older versions of puppet don't know about the --to_yaml option #119

Merged
merged 3 commits into from
Nov 26, 2017

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Nov 24, 2017

switching back to scanning the result

fixes #118

@sathieu
Copy link

sathieu commented Nov 24, 2017

Thanks for this PR.

I have another error:

Error: Could not run: Could not find init script for 'alert_manager'

@tuxmea
Copy link
Member Author

tuxmea commented Nov 24, 2017

@sathieu next version with error handling. I am curious where the error is happening and whether the begin rescue block is helpful here.

@sathieu
Copy link

sathieu commented Nov 24, 2017

The rescue is not called because the error is in the puppet call.

This works:

Facter.add('prometheus_alert_manager_running') do
  setcode do
    Facter::Core::Execution.execute('puppet resource service alert_manager 2>&1').scan('running')[0]
  end
end

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Nov 25, 2017
@bastelfreak
Copy link
Member

Thanks for the PR!

@bastelfreak bastelfreak merged commit 4ef5802 into voxpupuli:master Nov 26, 2017
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
older versions of puppet don't know about the --to_yaml option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Could not parse application options: invalid option: --to_yaml
4 participants